Dump parallel failure to log unless "debug" is "true" #1645
Conversation
| function debug_print(varargin) | ||
| if debug | ||
| fprintf(varargin{:}); | ||
| else | ||
| fprintf(fh, varargin{:}); | ||
| end | ||
| end |
There was a problem hiding this comment.
completely agree with need for test. Absolutely not-obvious that fh is global variable and it propagated correctly.
The idea itself looks reasonable.
oerc0122
force-pushed
the
silence-par-errors
branch
from
66f81bf to
02ce952
Compare
oerc0122
changed the title
| MExceptions_outputs(i) = true; | ||
| debug_print('Task %d failed. Error %s; Message %s\n', ... | ||
| i, outputs{i}.identifier, outputs{i}.message); | ||
|
|
There was a problem hiding this comment.
I was playing with various failing jobs during the week and would argue that this should be reconsidered.
When job fails, it prints short list of messages stating worker failed (one row)
Then it prints detailed information.
The detailed information should go into log, that's correct.
But short info about job failure should remain. Then it should be one string
see file .... for details of the issue.
I do not want to investigate this issue too deeply, but have a feeling that modified changes are too brief. The suggested solution would provide much better user experience.
oerc0122
force-pushed
the
silence-par-errors
branch
4 times, most recently
from
7efef8c to
bdcd1e5
Compare
oerc0122
force-pushed
the
silence-par-errors
branch
from
bdcd1e5 to
a5a8f13
Compare
Fixes #1609