stored hashes as saved field #1615
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashes were removed from the saved fields as the hash values were not always preserved across save/load, especially across platforms. This PR restores them in what is hoped to be a platform-independent fashion
CM:10.04.24: Running this PR on CI and locally works on Matlab 2019b onwards (at least 2021b) but not on 2018b. The issue appears to be a small change in numerical values ~10^-15 in that earlier version compared with now. We are looking at truncating numerical mantissas, but in the meantime this PR is converted to draft as unusable until the platform dependency is resolved.