Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make instruments, samples and detectors hashable #1790

Open
abuts opened this issue Dec 16, 2024 · 0 comments
Open

make instruments, samples and detectors hashable #1790

abuts opened this issue Dec 16, 2024 · 0 comments
Assignees
@abuts

Comments

@abuts
Copy link
Member

abuts commented Dec 16, 2024

Main purpose of hashable is to provide quick comparison routine for objects, stored in container, which is highly efficient.
hashable class is implemented and this ticket is to modify the classes to be in the containers to be hashable.
@abuts abuts self-assigned this Dec 16, 2024
abuts added a commit that referenced this issue Dec 16, 2024
@abuts
Re #1790 Formally modified instrument-s to be hashable. Detectors inc…
fe8712f 
…omplete. Tests needed
abuts added a commit that referenced this issue Dec 16, 2024
@abuts
Re #1790 seems all container's objects are properly hashable now. wha…
0cc79e7 
…t is left --testing this
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 bunch of unit tests for hashable objects and some issues ide…
7823015 
…ntified by these tests.
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 bugs in IX_fermi_chopper.m and IX_doubledisk_chopper.m
9632be9
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 unit tests for all IX_instrument classes to be hashable.
88153a2
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 unit tests to ensure that hashes persists in unique_ref_cont…
26a0293 
…ainer
@abuts abuts mentioned this issue Dec 17, 2024
Open
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 complex issue with recursive check of combine arguments whil…
9c85f5d 
…e calculating hashes.
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 fixed test_get_revert_bytestream.m -- failing as instrument …
2d08b99 
…components are now hashable so their image stores hash
abuts added a commit that referenced this issue Dec 17, 2024
@abuts
Re #1790 fixed test_instrument_classes
b4c424a
@abuts abuts mentioned this issue Dec 18, 2024
Open
6 tasks
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 subtle bug in serializable preventing overloading to_struct …
e6d6ccb 
…in case of recursion.
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 minor changes to finish hashable
6a08643
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 Merge branch '1147_eq_to_toll' into 1790_hashable_obj
02c3628 
# Conflicts:
#	herbert_core/utilities/maths/equal_to_tol.m
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 Minor niceness and clarity to comparison methods.
3e9e646
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 changes from review
90c1ebc
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 Partially fix issue with unique IX_detector_array container,…
d8c8d26 
… comparing detectors on the basis of their positions and not the name of the file, they are obtained from.
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 Fixed text_main_mex The value of a hash for current IX_instr…
c9d4c4a 
…ument is different now.
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 Ensure hashable array is never empty and two different empty…
eae18dd 
… hashable objects have different hashes.
abuts added a commit that referenced this issue Dec 22, 2024
@abuts
Re #1790 Reset stored hash according to changes
ca37ed6
abuts added a commit that referenced this issue Dec 23, 2024
@abuts
Re #1790 made object_lookup.m use the same hash function and approach…
761c95b 
… as hashable classes. Small simplification to sort method.
abuts added a commit that referenced this issue Dec 24, 2024
@abuts
Re #1790 Attempt to solve issue with test_tobyfit_cuts
0d8f5a4
abuts added a commit that referenced this issue Dec 25, 2024
@abuts
Re #1790 hacking test_tobyfit_refine_moderator
21efed3
abuts added a commit that referenced this issue Dec 25, 2024
@abuts
Re #1790 Hacking test_TF_components. Adder relative tolerance in test…
716fe4f 
…_tobyfit_refine_moderator.m
abuts added a commit that referenced this issue Dec 25, 2024
@abuts
Re #1790 trying to fix jenkins tests. Fixed sqw with detector_array i…
504597a 
…ssue
abuts added a commit that referenced this issue Dec 26, 2024
@abuts
Re #1790 fixed loading sqw version 4 and should fix majority of tests…
66282a8 
… in test_TF_components
abuts added a commit that referenced this issue Dec 26, 2024
@abuts
Re #1790 bug in set_from_old_struct_.m -- should fix couple of unit t…
73ab63c 
…ests.
abuts added a commit that referenced this issue Dec 26, 2024
@abuts
Re #1790 Attemt to hack test_tobyfit_refine_moderator.m . Works on my…
e394083 
… machines
abuts added a commit that referenced this issue Dec 26, 2024
@abuts
Re #1790 issue with accuracy of restun calculations on different OS
06abbd2
abuts added a commit that referenced this issue Dec 27, 2024
@abuts
Re #1790 minor changes and comment related to ticket #1799
e672c7c
abuts added a commit that referenced this issue Dec 29, 2024
@abuts
Re #1790 minor bug in unuque_references_container. list should return…
508a16e 
… value
abuts added a commit that referenced this issue Dec 29, 2024
@abuts
Re #1790 Skip failing tests until #1791 fixed
b35ba2f
abuts added a commit that referenced this issue Dec 29, 2024
@abuts
Re #1790 hiding other failing statement to resolve in Re #1791
f006fe9
abuts added a commit that referenced this issue Dec 30, 2024
@abuts
Re #1790 formal change to kick-up the build.
58adab8
abuts added a commit that referenced this issue Dec 31, 2024
@abuts
Re #1790 formal change to kick-on the build
e8b9884
@abuts abuts mentioned this issue Jan 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuts abuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abuts