Re #1790 subtle bug in serializable preventing overloading to_struct …

…in case of recursion.

herbert_core/classes/instrument_classes/instrument/detectors/@IX_detector_array/IX_detector_array.m

@@ -596,6 +596,11 @@
             % Current version of class definition
             ver = 1;
         end
+        function flds = hashableFields(~)
+            % Return cellarray of properties defining the class hash for
+            % comparison
+            flds = {'det_bank', 'filename'};
+        end
 
         function flds = saveableFields(~)
             % Return cellarray of properties defining the class

herbert_core/utilities/classes/@hashable/eq.m

@@ -2,7 +2,6 @@
 % Return a logical variable stating if two serializable objects are equal or not
 %
 %   >> [iseq, mess] = eq (obj1, obj2)
-%   >> [iseq, mess] = eq (obj1, obj2, p1, p2, ...)
 %
 % Input:
 % ------
@@ -11,6 +10,10 @@
 %   obj2        Object on right-hand side
 %
 % See also equal_to_tol
+if ~isa(obj2,class(obj1))
+    iseq = false;
+    return;
+end
 if ~all(size(obj1)==size(obj2))
     iseq = false;
     return;

herbert_core/utilities/classes/@hashable/ne.m

@@ -12,6 +12,11 @@
 %
 % See also equal_to_tol
 
+% classes are different
+if ~isa(obj2,class(obj1))
+    isneq = true;
+    return;
+end
 % sizes of objects are different
 if ~all(size(obj1)==size(obj2))
     isneq = true;

herbert_core/utilities/classes/@serializable/private/from_bare_struct_.m

@@ -104,7 +104,7 @@
     if isstruct(val)
         if isfield(val,'serial_name')
             % Structure is one that has been created by to_struct
-            val = serializable.from_struct (val);
+            val = obj.from_struct (val);
         end
     end
     obj.(field_name) = val;