Use constraints file in tox #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
force-pushed
the
345-use-constraints
branch
2 times, most recently
from
a27ce05 to
2dece09
Compare
oerc0122
force-pushed
the
345-use-constraints
branch
from
2dece09 to
59ddb0c
Compare
oerc0122
force-pushed
the
345-use-constraints
branch
7 times, most recently
from
9d55213 to
4b4622e
Compare
oerc0122
force-pushed
the
345-use-constraints
branch
4 times, most recently
from
758e761 to
a1bb715
Compare
ajjackson
force-pushed
the
split-rls-tests
branch
from
c13c818 to
15fd97d
Compare
oerc0122
force-pushed
the
345-use-constraints
branch
from
a1bb715 to
77c74aa
Compare
PyPI test results 22 files 22 suites 52m 4s ⏱️ Results for commit f32fb0e. ♻️ This comment has been updated with latest results. |
oerc0122
force-pushed
the
345-use-constraints
branch
from
6f9dcc2 to
fea9faf
Compare
oerc0122
force-pushed
the
345-use-constraints
branch
from
fea9faf to
f32fb0e
Compare
|
Looks like it's all passing again, now. Hopefully nothing to worry about 😅 |
There's always more to worry about. |
ajjackson
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
This all looks very clean and DRY, good stuff!
I've set a manual dispatch test run going here, in case there is any funny business on Python 3.11 or Intel Mac https://github.com/pace-neutrons/Euphonic/actions/runs/12439069788
Assuming all goes well with that I think this is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use constraints file in tox min-requirements. Also attempt to simplify testing commands.
Closes #345