Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.0.post1 #342

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Release 1.4.0.post1 #342

merged 3 commits into from
Dec 12, 2024

Conversation

ajjackson
Copy link
Collaborator

This post-release makes some changes to the source-distribution build process:

  • A bug is fixed in the version-numbering script; this particularly affected Windows
  • A copies of the unit tests and documentation were mistakenly included
    in tarballs, making them excessively large. This is no longer present.

@ajjackson
Copy link
Collaborator Author

ajjackson commented Dec 12, 2024

Tag has been applied with set-version action: no new commit was created as files already had correct version information.

Wheel build action (without upload) running here: https://github.com/pace-neutrons/Euphonic/actions/runs/12300360072

ajjackson and others added 2 commits December 12, 2024 16:22
While the version is generally represented as e.g. v1.4.0.post1,
in CITATION.cff the usual style is to omit the "v" and our existing
release.py script assumes this.

Solve the problem by tweaking the version-number-writing action.
@ajjackson
Copy link
Collaborator Author

ajjackson commented Dec 12, 2024

The release.py dry-run failed, complaining that CITATION.cff had "v1.4.0.post1" and not "1.4.0.post1". The version-number-writer has been updated and run again, creating a commit.

Running wheel build tests again at https://github.com/pace-neutrons/Euphonic/actions/runs/12300608552

(I really am going to be surprised if these wheels fail at release time after this much testing...)

@ajjackson ajjackson merged commit baa304c into master Dec 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant