-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version number action #340
Conversation
This looks good now, we have successful runs when only the tag is updated and when both tag and files are updated And the tags are showing up in the list of repository tags. (I suppose they should be removed as these are not really official release candidates? But not much harm done if no release packages are made from them.) |
Sometimes we might run this when the version number is already correct; e.g. when cleaning up from a failed release attempt. In that case, skip the commit and apply the tag to the existing last commit.
6228c88
to
1ea49fb
Compare
Wheel/package builds are here and got the version number wrong 😭 https://github.com/pace-neutrons/Euphonic/actions/runs/12284927698 |
Ah, I see part of the problem: while rebasing I moved this history away from the tagged commits. That explains why it is seeing v1.4.0 tags 😅 |
Ok, with a new tag the build names all look good again. I'd like to add a step that validates the version number format and adds a "v" if missing. |
Unit tests are running here, not clear why they don't show up in the checklist. |
Developing a github action that sets the version number in all the relevant places, for use in the release process.
This is part of #326