Bump numpy requirement to 1.24, matching Mantid #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While transitioning to Numpy 2.0 it is helpful to reduce the range of versions being used and tested. As we are changing other requirements in this release, it is a good time to bump Numpy. Here we also update the build/release workflow to add Python 3.12 and build with Numpy 2.0; these builds _should_ also work with all the supported numpy 1.x.
I'm seeing some odd openblas-related warnings
|
I'm seeing some slightly scary warnings on the minrequirements tests like this: which suggests some issues with the openblas linking. But... the test still passes? |
Pinning numpy to a known-good versions still leads to openblas-related warnings, let's see if Scipy is involved.
With numpy alone, we see no openblas warnings. Scipy is next suspect...
Finally we have the culprit: threadpoolctl. That makes sense, actually, as this library is responsible for getting info about openblas environment and that can vary between builds. I note that a very recent (April 2024) threadpoolctl release adds support for "Scientific Python builds of OpenBLAS." That seems plausible, but first let's see if a slightly gentler version bump makes any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While transitioning to Numpy 2.0 it is helpful to reduce the range of versions being used and tested. As we are changing other requirements in this release, it is a good time to bump Numpy.
Here we also update the build/release workflow to add Python 3.12 and build with Numpy 2.0; these builds should also work with all the supported numpy 1.x.