Skip to content

Commit

Permalink
Remove test that optimise-dipole-parameter returns 0.75
Browse files Browse the repository at this point in the history
On different systems the optimum may be different, and
to get a consistent answer the number of q-points should
be fairly high, which has high overhead. Better not to
test a specific case as it is unreliable
  • Loading branch information
rebeccafair committed Sep 8, 2021
1 parent 4dbf557 commit e82c0ec
Showing 1 changed file with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@
@pytest.mark.integration
class TestRegression:

def test_optimal_is_0_75(self):
# Need a high-enough n to get a good timing, but
# can be slow for testing, so reduce the parameters that
# we test
optimal_dipole_parameter = calculate_optimum_dipole_parameter(
quartz_castep_bin, dipole_parameter_min=0.5,
dipole_parameter_max=1.25)[0]
assert optimal_dipole_parameter == 0.75

def test_default_dipole_parameters(self):
tested_parameters = calculate_optimum_dipole_parameter(
quartz_castep_bin, n=5)[3]
Expand Down

0 comments on commit e82c0ec

Please sign in to comment.