Skip to content

Commit

Permalink
Fix nits from Steffen.
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-dilorenzo committed Apr 23, 2024
1 parent 42d26a4 commit d82cb26
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
13 changes: 7 additions & 6 deletions docs/v1/P4Runtime-Spec.mdk
Original file line number Diff line number Diff line change
Expand Up @@ -1293,8 +1293,8 @@ message PkgInfo {
// Miscellaneous metadata, structured; a way to extend PkgInfo
repeated StructuredAnnotation structured_annotations = 9;
// If set, specifies the properties that the underlying platform should have.
// If the platform does conform to these properties, the server should reject
// the P4Info when used with a SetForwardingPipelineConfigRequest.
// If the platform does not conform to these properties, the server should
// reject the P4Info when used with a SetForwardingPipelineConfigRequest.
PlatformProperties platform_properties = 11;
}
~ End Proto
Expand All @@ -1303,14 +1303,15 @@ where the `PlatformProperties` message looks as follows:
~ Begin Proto
// Used to describe the required properties of the underlying platform.
message PlatformProperties {
// The maximum number of multicast entries (i.e. multicast groups) that the
// platform is expected to support. If 0, there are no requirements.
// The minimum number of multicast entries (i.e. multicast groups) that the
// platform is required to support. If 0, there are no requirements.
int64 multicast_group_table_size = 1;
// The maximum number of replicas that the platform is expected to support
// The minimum number of replicas that the platform is required to support
// across all groups. If 0, there are no requirements.
int64 multicast_group_table_total_replicas = 2;
// The largest number of replicas that the platform is expected to support per
// The number of replicas that the platform is required to support per
// group/entry. If 0, `multicast_group_table_total_replicas` should be used.
// Must be no larger than `multicast_group_table_total_replicas`.
int64 multicast_group_table_max_replicas_per_entry = 3;
}
~ End Proto
Expand Down
9 changes: 5 additions & 4 deletions proto/p4/config/v1/p4info.proto
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,15 @@ message Documentation {

// Used to describe the required properties of the underlying platform.
message PlatformProperties {
// The maximum number of multicast entries (i.e. multicast groups) that the
// platform is expected to support. If 0, there are no requirements.
// The minimum number of multicast entries (i.e. multicast groups) that the
// platform is required to support. If 0, there are no requirements.
int64 multicast_group_table_size = 1;
// The maximum number of replicas that the platform is expected to support
// The minimum number of replicas that the platform is required to support
// across all groups. If 0, there are no requirements.
int64 multicast_group_table_total_replicas = 2;
// The largest number of replicas that the platform is expected to support per
// The number of replicas that the platform is required to support per
// group/entry. If 0, `multicast_group_table_total_replicas` should be used.
// Must be no larger than `multicast_group_table_total_replicas`.
int64 multicast_group_table_max_replicas_per_entry = 3;
}

Expand Down

0 comments on commit d82cb26

Please sign in to comment.