Skip to content

Commit

Permalink
Rename multicast_table to multicast_group_table.
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-dilorenzo committed Apr 19, 2024
1 parent 6783e47 commit d630f78
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
12 changes: 6 additions & 6 deletions docs/v1/P4Runtime-Spec.mdk
Original file line number Diff line number Diff line change
Expand Up @@ -1305,13 +1305,13 @@ where the `PlatformProperties` message looks as follows:
message PlatformProperties {
// The maximum number of multicast entries (i.e. multicast groups) that the
// platform is expected to support. If 0, there are no requirements.
int64 multicast_table_size = 1;
int64 multicast_group_table_size = 1;
// The maximum number of replicas that the platform is expected to support
// across all groups. If 0, there are no requirements.
int64 multicast_table_total_replicas = 2;
int64 multicast_group_table_total_replicas = 2;
// The largest number of replicas that the platform is expected to support per
// group/entry. If 0, `multicast_table_total_replicas` should be used.
int64 multicast_table_max_replicas_per_entry = 3;
// group/entry. If 0, `multicast_group_table_total_replicas` should be used.
int64 multicast_group_table_max_replicas_per_entry = 3;
}
~ End Proto

Expand Down Expand Up @@ -1359,8 +1359,8 @@ Above we see several different types of annotations:
annotation, separated by commas. Each key must only appear once and the
compiler must reject the program if one appears multiple times. The `key`s
must be from among the message fields inside `PlatformProperty`, for example,
`multicast_table_size` or `multicast_table_total_replicas`. Each key-value
pair assigns a value to the corresponding field inside the single
`multicast_group_table_size` or `multicast_group_table_total_replicas`. Each
key-value pair assigns a value to the corresponding field inside the single
`PlatformProperty` message inside the program's P4Info.

* `@<anything else>` - This will create a `PkgInfo.annotation` entry
Expand Down
12 changes: 6 additions & 6 deletions proto/p4/config/v1/p4info.proto
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ message Documentation {
message PlatformProperties {
// The maximum number of multicast entries (i.e. multicast groups) that the
// platform is expected to support. If 0, there are no requirements.
int64 multicast_table_size = 1;
int64 multicast_group_table_size = 1;
// The maximum number of replicas that the platform is expected to support
// across all groups. If 0, there are no requirements.
int64 multicast_table_total_replicas = 2;
int64 multicast_group_table_total_replicas = 2;
// The largest number of replicas that the platform is expected to support per
// group/entry. If 0, `multicast_table_total_replicas` should be used.
int64 multicast_table_max_replicas_per_entry = 3;
// group/entry. If 0, `multicast_group_table_total_replicas` should be used.
int64 multicast_group_table_max_replicas_per_entry = 3;
}

// Top-level package documentation describing the forwarding pipeline config
Expand Down Expand Up @@ -87,8 +87,8 @@ message PkgInfo {
// Miscellaneous metadata, structured; a way to extend PkgInfo
repeated StructuredAnnotation structured_annotations = 9;
// If set, specifies the properties that the underlying platform should have.
// If the platform does conform to these properties, the server should reject
// the P4Info when used with a SetForwardingPipelineConfigRequest.
// If the platform does not conform to these properties, the server should
// reject the P4Info when used with a SetForwardingPipelineConfigRequest.
PlatformProperties platform_properties = 11;
}

Expand Down

0 comments on commit d630f78

Please sign in to comment.