Small TC fixes #5002
Open
Small TC fixes #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ride cases
In cases where the tc_may_override annotation is associate with an
action that has a parameter with a tc_type annotation, the compiler
is emitting the parameters declaration in p4tc_filter_fields incorrectly.
For example in tc_may_override_example_04:
struct p4tc_filter_fields {
__u32 pipeid;
__u32 handle;
__u32 classid;
__u32 chain;
__u32 blockid;
__be16 proto;
__u16 prio;
ipv4 ipv4_tbl_1_next_hop_ipv4addr;
};
"ipv4" is not a valid C type, so this won't compile
Also, in the case of bit types that are not equivalent to a standard C
type (u8, u16, u32, u64), the compiler is emitting the type incorrectly.
Let's say, in the previous example, that the type for ipv4addr was bit<33>,
the compiler would've emitted the following:
struct p4tc_filter_fields {
__u32 pipeid;
__u32 handle;
__u32 classid;
__u32 chain;
__u32 blockid;
__be16 proto;
__u16 prio;
__u33 ipv4_tbl_1_next_hop_ipv4addr;
};
This commit fixes this by converting tc_type annotated action parameters
to their corresponding C type and converts any non C standard bit type
into a u8 array rounded up to the nearest byte
Signed-off-by: Victor Nogueira <[email protected]>
In struct p4tc_table_entry_create_bpf_params__local we've adopted profile_id instead of aging_ms. This commits updates the field name in the generated output Signed-off-by: Victor Nogueira <[email protected]>
|
@komaljai please take a look when you have some time |
Add missing kfuncs and remove some deprecated ones Signed-off-by: Victor Nogueira <[email protected]>
vbnogueira
force-pushed
the
tc_test_fixes
branch
from
8066476
to
7f4729a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst writing the automated test tools for the tc backend, I ended up finding some compilation bugs when compiling some generated C files from the testdata samples directory
This PR fixes those issues, describes them in more detail in the commit messages and updates
pna.h