Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abseil string helpers #4971

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Add abseil string helpers #4971

merged 7 commits into from
Nov 6, 2024
+670 −691

Commits on Nov 6, 2024

  1. Add abseil formatters for: 

      - cstring
  - IR::Node
  - IR::ID

This improves the code itself as we no longer need to do explicit
.toString() / .string_view() calls. Also, this prints directly to
sink, providing some performance improvements.

Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3dfc057 View commit details
    Browse the repository at this point in the history

  2. Ensure that conversion from cstring to char* is explicit 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a8749b2 View commit details
    Browse the repository at this point in the history

  3. Update control-plane as now conversion cstring => string_view is not … 

    …ambiguous

Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    cbaddb7 View commit details
    Browse the repository at this point in the history

  4. Remove more instances of .string_view() calls 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    09a42ed View commit details
    Browse the repository at this point in the history

  5. Fix some obvious Tofino cstring misuse 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8c78dfc View commit details
    Browse the repository at this point in the history

  6. Clarify abseil formatter helpers 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    31e2146 View commit details
    Browse the repository at this point in the history

  7. Review suggestions 

    Signed-off-by: Anton Korobeynikov <[email protected]>
    @asl
    asl committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c83e2e2 View commit details
    Browse the repository at this point in the history