Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore brew dependency installation to fix breakages on MacOS CI. #4950

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Oct 8, 2024

No description provided.

tools/install_mac_deps.sh Outdated Show resolved Hide resolved
@fruffy fruffy changed the title Try to use Boost 1.86 instead to fix MacOS failures. Ignore brew dependency installation to fix breakages on MacOS CI. Oct 8, 2024
@fruffy fruffy marked this pull request as ready for review October 8, 2024 22:19
@fruffy fruffy enabled auto-merge October 8, 2024 22:55
Copy link
Contributor

@asl asl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but.. meh :(

@fruffy fruffy added this pull request to the merge queue Oct 8, 2024
@fruffy
Copy link
Collaborator Author

fruffy commented Oct 8, 2024

Looks reasonable, but.. meh :(

#4663 will bring salvation, I am telling ya.

We could also look into a different build manager for MacOS. Or just install boost from scratch, but not a big fan of that..

Merged via the queue into main with commit fbbd2f7 Oct 8, 2024
19 checks passed
@fruffy fruffy deleted the fruffy/macos_fix branch October 8, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants