Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor error_helper and around #4686

Merged
merged 12 commits into from
Jun 2, 2024
Merged

Refactor error_helper and around #4686

merged 12 commits into from
Jun 2, 2024

Commits on Jun 2, 2024

  1. Modernize the code: 

      - Use universal references
  - Consistently forward the packs
  - Ensure we move things passed by value
  - Use C++17 constructs
    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    f4d21a6 View commit details
    Browse the repository at this point in the history

  2. Simplify parser_error: switch for variadic functions to variadic temp… 

    …lates.

Removes some layers of indirection.
    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    5a8e969 View commit details
    Browse the repository at this point in the history

  3. Greatly simplify error_helper. Unbreak HasToString while there.

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    1afe532 View commit details
    Browse the repository at this point in the history

  4. Ensure we do not do extra copy of std::string during toString

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    9e8d227 View commit details
    Browse the repository at this point in the history

  5. Forward-declare big_int

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    f052206 View commit details
    Browse the repository at this point in the history

  6. Consolidate all => string conversions in a single place: 

     - prefer dbprint() method for operator<<(ostream&) when present
 - otherwise, fallback to toString(), if present
    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    1c2c36a View commit details
    Browse the repository at this point in the history

  7. Simplify bug_helper more, hide stuff into dedicated namespace to redu… 

    …ce amount of visible overload variants
    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    0d86561 View commit details
    Browse the repository at this point in the history

  8. Unbreak for Boost < 1.84

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    34b2b3f View commit details
    Browse the repository at this point in the history

  9. Simplify

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    a60e9d8 View commit details
    Browse the repository at this point in the history

  10. Silence broken gcc warning

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    e3a9295 View commit details
    Browse the repository at this point in the history

  11. Try to unbreak bazel. Again

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    e7c8042 View commit details
    Browse the repository at this point in the history

  12. FIXME was clarified

    @asl
    asl committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b54b93b View commit details
    Browse the repository at this point in the history