-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update expected contents of p4info files. #4356
Conversation
Can you rebase and check whether this still applies? |
Ok, I will rebase after checking that the CI passes. |
#4352, which is approved should also fix this. But we can merge yours first to unblock you. |
Do any of the jobs spuriously fail? I noticed that the CI was red earlier, and now it is yellow, so I'm assuming that either someone re-triggered the failing job or it was re-triggered automatically, and I'm wondering if it is the same job that is currently failing in #4357. |
Ah, looks like it failed again here |
This has been recently, unclear what changed to cause this failure. A fix might be to increase the waiting time in the PTF tests. |
I merged #4352, which should make this PR obsolete. |
Thank you @fruffy |
This is what I get when I run
P4TEST_REPLACE=1 make check
onmain
ToT.