Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 45 support #150

Merged
merged 15 commits into from
Apr 3, 2024
Merged

GNOME 45 support #150

merged 15 commits into from
Apr 3, 2024

Conversation

mwilck
Copy link
Collaborator

@mwilck mwilck commented Oct 16, 2023

This PR adds GNOME shell 45 support to Argos, at the cost of removing support for all previous GNOME versions.

The first patches (up to 5ae5a97) are actually cleanups for the current ("GNOME shell up to 44") code which make applying the GNOME 45 changes more straighforward.

Fixes #149.

"Lang" is deprecated and shouldn't be used any more.
This breaks compatibility with GNOME shell < 3.32.

Signed-off-by: Martin Wilck <[email protected]>
We can't support older GNOME shell versions any more, anyway.

Signed-off-by: Martin Wilck <[email protected]>
The "mainloop" import exists no more. GLib functions can be
called directly for creating and handling timeout events.

Signed-off-by: Martin Wilck <[email protected]>
GNOME 45 support is exclusive with all prior GNOME shell versions.

Signed-off-by: Martin Wilck <[email protected]>
@mwilck mwilck linked an issue Oct 16, 2023 that may be closed by this pull request
@mwilck mwilck mentioned this pull request Jan 10, 2024
Copy link

@hobbypunk90 hobbypunk90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button.js, line 36:

Utilities.getActor(this).add_actor(this._lineView); to Utilities.getActor(this).add_child(this._lineView);

Fixes for gnome 46 🙂

@nocreativi
Copy link

Fixes for gnome 46 🙂

Works great - thank you! (I also changed "45" to "46" in metadata.json.)

michel-slm and others added 2 commits March 28, 2024 17:33
Use `add_child` instead of the removed (not deprecated) `add_actor`

https://gjs.guide/extensions/upgrading/gnome-shell-46.html#clutter-container

- Compatibility with GNOME 45 tested on Fedora 39
- Compatibility with GNOME 46 tested on Fedora 40 beta.

Resolves #157

Signed-off-by: Michel Lind <[email protected]>
@mwilck
Copy link
Collaborator Author

mwilck commented Apr 3, 2024

As GNOME 46 is out now, and GNOME 45 has been out for 6 months, I am merging this into the master branch now, finally.

@mwilck mwilck merged commit 0449229 into master Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gnome 45 compatibility
4 participants