Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchMethodError on super.getDirtyBounds() #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ypresto
Copy link

@ypresto ypresto commented Aug 8, 2016

RippleDrawable#getDirtyBounds() calls super.
It is API >= 21 method but is missing from LollipopDrawable.
This exception only happens on pre-lollipop Androids.

RippleDrawable#getDirtyBounds() calls super.
@kovalevsky
Copy link

+1
Faced with same issue.

@e16din
Copy link

e16din commented Oct 1, 2016

+1.
Thank you @ypresto for solution.

 java.lang.NoSuchMethodError: codetail.graphics.drawables.LayerDrawable.getDirtyBounds
                                                                   at codetail.graphics.drawables.RippleDrawable.getDirtyBounds(RippleDrawable.java:865)
                                                                   at codetail.graphics.drawables.RippleDrawable.draw(RippleDrawable.java:610)
                                                                   at android.widget.FrameLayout.draw(FrameLayout.java:498)
                                                                   at android.view.View.getDisplayList(View.java:13362)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.support.v7.widget.RecyclerView.drawChild(RecyclerView.java:4184)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.draw(View.java:14468)
                                                                   at android.support.v7.widget.RecyclerView.draw(RecyclerView.java:3593)
                                                                   at android.view.View.getDisplayList(View.java:13362)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2947)
                                                                   at android.view.View.draw(View.java:14468)
                                                                   at android.view.View.getDisplayList(View.java:13362)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.support.design.widget.CoordinatorLayout.drawChild(CoordinatorLayout.java:1192)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.support.v4.widget.DrawerLayout.drawChild(DrawerLayout.java:1383)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.draw(View.java:14468)
                                                                   at android.widget.FrameLayout.draw(FrameLayout.java:472)
                                                                   at android.view.View.getDisplayList(View.java:13362)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                   at android.view.ViewGroup.drawChild(ViewGroup.java:3103)
                                                                   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2940)
                                                                   at android.view.View.getDisplayList(View.java:13357)
                                                                   at android.view.View.getDisplayList(View.java:13404)
                                                                   at android.view.View.draw(View.java:14182)
                                                                at android.view.ViewGroup.drawChild(ViewGroup.java:31

@addisonElliott
Copy link

addisonElliott commented Feb 10, 2019

Hate to bring up a dead topic, but I ran into this issue and I wanted to share my thoughts in case it helps someone else.

Since there hasn't been much activity on this repository, I created a fork and cleaned up the code. My library can be found here, I hope to keep it up-to-date and maintained: https://github.com/addisonElliott/RippleDrawable

Check out the README for instructions on installing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants