WIP: Combine KmerCountTables with Add() #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e skip_bad_kmers behaviour.
|
Not sold on having a subtract method, might get rid of it. |
…e after being dropped
Adamtaranto
changed the title
|
Ditched the subtract function. Need to decide if we should allow adding a table to itself - this creates issues around borrowing the same object multiple times and is generally a bit of a pain. Maybe just raise error if trying to add table to itself? |
|
I'm giving up on trying to check if self and other are the same table. Just let it die with borrow error. |
|
hah! over in #83 I created a |
|
I am wondering if we want to avoid doing merges in parallel fashion? The locking is going to add a lot of overhead I think. |
|
Should I fully remove parallelisation from the function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KmerCountTableKmerCountTableCloses #62