Ensure oneOf exclusivity when merging schemas.
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
significantly worse
ahl
commented
Jan 17, 2024
Comment on lines
+497
to
+499
| // We don't care if a property we're saying is not | ||
| // required was not present in the properties map. | ||
| let _ = properties.remove(not_required); |
There was a problem hiding this comment.
alternatively we could do something like this:
let _ = properties.insert(not_required, Schema::Bool(false));To indicate that this must not be present. The resulting types might be ugly or we could look for Option<Never> and do something different.
ahl
commented
Jan 17, 2024
Comment on lines
+1031
to
+1035
| // So. We merged the properties and we merged the array of | ||
| // properties that are required. We use the absence of a property | ||
| // in the properties map to indicate that the property must *not* | ||
| // be present. This is imprecise, but allows us to make progress | ||
| // without a most significant conversion to a new representation. |
There was a problem hiding this comment.
we could change this to see if the property was invalid i.e. Schema::Bool(false)
ahl
commented
Jan 17, 2024
ahl
commented
Jan 17, 2024
Comment on lines
+886
to
+889
| pub enum ShouldBeExclusive { | ||
| Variant0 { id: String }, | ||
| Variant1 { reference: String }, | ||
| } |
There was a problem hiding this comment.
later it would be good if we could boil this down to
pub enum ShouldBeExclusive {
Id(String),
Reference(String),
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, but it's pretty close.
oneOfexpansion is insufficiently exclusive #420, some generated types aren't enforcing sufficient exclusivity. We do seem to have a huge amount of generated json that's turning into huge doc comments. This seems like a problem and the doc comments aren't actually useful for types whose json is sort of fabricated rather than coming from the original document.join_schemaswhich I've stopped using (for reasons that elude me).Fixes #420.