nvme: don't fail on abort cmd #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmooney
approved these changes
Dec 4, 2023
rcgoodfellow
pushed a commit
that referenced
this pull request
Dec 5, 2023
`Abort` is a mandatory NVMe command and we were previously just returning `STS_INTERNAL_ERR` (`06h - Internal Device Error` ). Even without fully supporting aborting commands we can do better than that since it's a best effort command. This change just adds some validation and immediately completes an abort request indicating the command in question _wasn't_ aborted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abortis a mandatory NVMe command and we were previously just returningSTS_INTERNAL_ERR(06h - Internal Device Error). Even without fully supporting aborting commands we can do better than that since it's a best effort command.This change just adds some validation and immediately completes an abort request indicating the command in question wasn't aborted.