Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump softnpu #577

Merged
merged 6 commits into from
Dec 15, 2023
Merged

bump softnpu #577

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2333d1
bump softnpu
rcgoodfellow Dec 4, 2023
a11fdd1
run clippy for falcon build against illumos
rcgoodfellow Dec 5, 2023
1a5ea36
throw in the towel for clippy on linux with falcon features
rcgoodfellow Dec 5, 2023
0622529
review feedback
rcgoodfellow Dec 14, 2023
eb86923
shift to main softnpu branch
rcgoodfellow Dec 14, 2023
4704d60
:facepalm:
rcgoodfellow Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
[alias]
xtask = "run --package xtask --quiet --"

[env]
# Currently required by Falcon due to
# https://github.com/rust-lang/cargo/issues/3946#issuecomment-973132993
CARGO_WORKSPACE_DIR = { value = "", relative = true }
1 change: 1 addition & 0 deletions .github/buildomat/jobs/falcon-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ rustc --version

banner check
ptime -m cargo check --features falcon
ptime -m cargo xtask clippy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just scope this to a cargo clippy ---features falcon? We don't need to run the non-falcon checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, also with --all-targets flag


banner build
ptime -m cargo build --features falcon --release \
Expand Down
Loading
Loading