Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when pause futures complete #575

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Log when pause futures complete #575

merged 1 commit into from
Nov 30, 2023

Conversation

jmpesp
Copy link
Contributor

@jmpesp jmpesp commented Nov 30, 2023

Fixes #537

@jmpesp jmpesp requested a review from gjcolombo November 30, 2023 21:04
gjcolombo
gjcolombo approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@gjcolombo gjcolombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

@jmpesp jmpesp merged commit 7157e8d into oxidecomputer:master Nov 30, 2023
10 checks passed
@jmpesp jmpesp deleted the log_pause_future_completion branch November 30, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcolombo gjcolombo gjcolombo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

want logging of completion of pause futures
2 participants
@jmpesp @gjcolombo