Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crucible to get fix 1000 #551

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update crucible to get fix 1000 #551

merged 1 commit into from
Oct 13, 2023

Conversation

leftwo
Copy link
Contributor

@leftwo leftwo commented Oct 13, 2023

Use regions_dataset path for apply_smf (#1000)

Use regions_dataset path for apply_smf (#1000)
@pfmooney
Copy link
Collaborator

I think we can skip this, since the crucible change does not impact the upstairs (or anything which propolis is consuming here).

@pfmooney
Copy link
Collaborator

Alan's investigation found that omicron requires matching crucible versions in propolis and other components, despite the fact that it has no measurable impact on behavior for this change. It's due to the fact that propolis-server is a dependency of sled-agent in omicron, via the simulated sled -agent component.

We should probably split out the mock server at some point so that we don't drag the entirety of propolis into omicron as a dependency, and can skip crucible updates which do not impact Upstairs (and thus propolis itself).

@leftwo leftwo merged commit 334df29 into master Oct 13, 2023
10 checks passed
@leftwo leftwo deleted the alan/crucible-to-1000 branch October 13, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants