-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up bits for CPUID customization #524
Conversation
lib/propolis/src/cpuid.rs
Outdated
TopoKind::StdB => { | ||
// Queries with invalid ecx will get all-zeroes | ||
set.insert(Ident(leaf, None), Entry::zero()); | ||
if self.has_smt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the above: if I want to test a guest OS with a zany set of outputs from a topology leaf, and I write a config file accordingly, and Propolis runs this logic, my settings will be silently overwritten. Should this return an error instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tweaked the leaf clearing behavior. LMK if that's fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a couple of things I want to make absolutely sure I'm grokking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's roll!
This is a first cut at making CPUID information customizable, rather than using the in-kernel vmm logic which applies limited transformations to the data exposed by the host CPU. Basic plumbing in propolis-lib is provided, which is wired into propolis-standalone. The same configuration syntax is defined for propolis-server, but it is going unused for now until some internal structure is hammered out.
Merged in c996261 |
This is a first cut at making CPUID information customizable, rather than using the in-kernel vmm logic which applies limited transformations to the data exposed by the host CPU. Basic plumbing in propolis-lib is provided, which is wired into propolis-standalone. The same configuration syntax is defined for propolis-server, but it is going unused for now until some internal structure is hammered out.