review feedback

oxidecomputer · Dec 14, 2023 · 0622529 · 0622529
1 parent 1a5ea36
commit 0622529
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/.github/buildomat/jobs/falcon-build.sh b/.github/buildomat/jobs/falcon-build.sh
@@ -18,7 +18,7 @@ rustc --version
 
 banner check
 ptime -m cargo check --features falcon
-ptime -m cargo xtask clippy
+ptime -m clippy --features falcon --all-targets
 
 banner build
 ptime -m cargo build --features falcon --release \

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/xtask/src/task_clippy.rs b/xtask/src/task_clippy.rs
@@ -39,17 +39,14 @@ pub(crate) fn cmd_clippy(strict: bool, quiet: bool) -> Result<()> {
         run_clippy(&["-p", "propolis-server", "--features", "omicron-build"])?;
 
     // Check the Falcon bits
-    #[cfg(target_os = "illumos")]
-    {
-        failed |= run_clippy(&[
-            "--features",
-            "falcon",
-            "-p",
-            "propolis-server",
-            "-p",
-            "propolis-client",
-        ])?;
-    }
+    failed |= run_clippy(&[
+        "--features",
+        "falcon",
+        "-p",
+        "propolis-server",
+        "-p",
+        "propolis-client",
+    ])?;
 
     // Check the mock server
     failed |= run_clippy(&["-p", "propolis-mock-server"])?;