Fix bool processing; clean date processing #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
The type failure is introduced in Zod 3.21.2. It does not happen with 3.21.1. At least some, maybe all, of these issues are ultimately about this, I think: colinhacks/zod#2196 |
| @@ -30,6 +25,9 @@ export function generateZodValidators(spec: OpenAPIV3.Document) { | |||
| */ | |||
| const IntEnum = <T extends readonly number[]>(values: T) => | |||
| z.number().refine((v) => values.includes(v)) as ZodType<T[number]>; | |||
|
|
|||
| /** Helper to ensure booleans provided as strings end up with the correct value */ | |||
| const SafeBoolean = z.preprocess(v => v === "false" ? false : v, z.coerce.boolean()) | |||
There was a problem hiding this comment.
This has the undesirable feature that '0' parses to true. Empty string works ok.
I think it would be good to match the API's behavior, which is to error on anything other than 'true' or 'false' or ''.
This matches that behavior:
const booleanString = z.enum(['true', 'false', '']).transform((v) => v === 'true')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
coerceto transform dates instead of the custom helper we were using previously