xtask ls-apis: try SSH access for dendrite #6840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that didn't work in CI as I had hoped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6839, at least from my perspective.
cargo metadataon the Maghemite workspace manifest fails, try re-running it with a set of environment variables that replaces Dendrite's Git URL with an SSH one. This removes the requirement to have a functioning ~/.netrc in order to run the full test suite locally; having a functioning SSH agent is significantly less hassle than fiddling with GitHub tokens.cargo xtask ls-apisexercising out of the already-quite-long build-and-test jobs. We've seen a flake on main where it took just over an hour to get to thels-apisbits by which time the GitHub token had already expired. build-and-test is already the longest required step to merge and it's not ideal to add more things to it.