Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nexus] add POST /v1/instances/{instance}/force-terminate #6795

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[nexus] add POST /v1/instances/{instance}/force-terminate #6795

wants to merge 13 commits into from

Commits on Oct 4, 2024

  1. plumbing for instance_force_terminate

    @hawkw
    hawkw committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3de530f View commit details
    Browse the repository at this point in the history

  2. implement force terminate

    @hawkw
    hawkw committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    afcd4b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. add tests

    @hawkw
    hawkw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    360c9cd View commit details
    Browse the repository at this point in the history

  2. fix bug due to idempotency 

    The sled-agent instance-ensure-unregistered API is idempotent, which is
right and proper...but it introduces an issue in the case of a
forgotten VMM after a sled-agent restart. The
instance-ensure-unregistered call will return `None` because sled-agent
doesn't know about that instance, but if this is the first time we have
discovered that sled-agent doesn't know about the instance, we will need
to move it to `Failed`. This commit fixes that.
    @hawkw
    hawkw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    34c3058 View commit details
    Browse the repository at this point in the history

  3. Update nexus/external-api/src/lib.rs 

    Co-authored-by: Greg Colombo <[email protected]>
    @hawkw @gjcolombo
    hawkw and gjcolombo authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    231c59f View commit details
    Browse the repository at this point in the history

  4. i guess i needed to clobber those

    @hawkw
    hawkw committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a86935a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. terminate active and target vmms

    @hawkw
    hawkw committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d6a2bd4 View commit details
    Browse the repository at this point in the history

  2. run instance-update saga synchronously

    @hawkw
    hawkw committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e841bd0 View commit details
    Browse the repository at this point in the history

  3. add a note about running 2 sagas

    @hawkw
    hawkw committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a69740d View commit details
    Browse the repository at this point in the history

  4. can't believe i forgot to do that

    @hawkw
    hawkw committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e632bed View commit details
    Browse the repository at this point in the history

  5. Update instance.rs 

    Co-authored-by: Greg Colombo <[email protected]>
    @hawkw @gjcolombo
    hawkw and gjcolombo authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e50af89 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. only run one saga (@gjcolombo is smarter than me)

    @hawkw
    hawkw committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d69a1ce View commit details
    Browse the repository at this point in the history

  2. cleanup mark_vmm_failed and sis_ensure_registered_undo

    @hawkw
    hawkw committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a923f2a View commit details
    Browse the repository at this point in the history