Attempt to handle "kstat-based metrics produce samples from the 1980's" #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #5899. Instead of checking for dates or anything based on the data sampled, this update starts collecting kstat samples (i.e. being interested in them) once the sled agent is synchronized with NTP. We leverage the metrics manager associated with the agent to now look for a new message and update the tracked links we've added/tracked thus far.
|
@bnaecker is definitely a different path than what you were looking at in the issue, but with the addition of the metrics manager, this seemed to be more robust, and it doesn't involve interval pooling or looking at specific ranges (of years/dates). |
zeeshanlakhani
commented
Sep 17, 2024
bnaecker
reviewed
Sep 18, 2024
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5899.
Instead of checking for dates or anything based on the data sampled, this update starts collecting kstat samples (i.e. being interested in them) once the sled agent is synchronized with NTP.
We leverage the metrics manager associated with the agent to now look for a new message and update the tracked links we've added/tracked thus far.