clarify which filesystem "filesystem_pool" describes #6587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm reading the code correctly, the
filesystem_poolfield in both inventory and blueprints identifies which zpool the zone's root filesystem will be constructed on. It took me a little while to figure this out so I wanted to add/clarify the couple of comments here.(I also think it would be clearer to call this
root_poolorroot_filesystem_pool. Zones have many filesystems, and at least two that might come from a zpool. But that's a much more invasive change I didn't want to make now, especially without asking people!)