Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/tuf-repo] multi-SP repos + use released SP images + add gimlet-e #3931

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Aug 22, 2023

This again changes the repo URL, so I will need to remember to update the script in meta after this lands.

@iliana iliana requested a review from jgallagher August 22, 2023 20:44
Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Naming things is hard - all seems fine to me. Once we can drop the pvt1 repo we'll only have one, at which point the suffix maybe isn't super relevant anymore? Could move to repo.zip, or oxide.zip, or oxide-repo.zip, ...

@@ -191,10 +191,10 @@ EOF
done
}
# usage: SERIES ROT_DIR ROT_VERSION BOARDS...
add_hubris_artifacts dogfood staging/dev cert-staging-dev-v1.0.0 gimlet-c psc-b sidecar-b
add_hubris_artifacts all staging/dev cert-staging-dev-v1.0.0 gimlet-c gimlet-d psc-b psc-c sidecar-b sidecar-c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go ahead and add gimlet-e too? It's available in dvt-dock. (We do not yet have new psc/sidecar hardware revisions.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well. I'll update that in a bit. (In the very near-term we're going to switch from using dvt-dock to tagged-and-released Hubris artifacts, hopefully tomorrow, and I was planning on adding it then.)

@iliana
Copy link
Contributor Author

iliana commented Aug 23, 2023

Upon further glancing at the generated manifest, this is listing duplicate ROT images way too many times. I'll rework the script tomorrow, although I may wait until I know how to pull newly-tagged SP images.

@iliana iliana marked this pull request as draft August 23, 2023 06:56
@iliana iliana changed the title s/dogfood/all/ and add gimlet-d/psc-c/sidecar-c [ci/tuf-repo] multi-SP repos + use released SP images + add gimlet-e + stop splitting the repo Aug 25, 2023
@iliana iliana requested a review from jclulow August 25, 2023 22:05
@iliana iliana marked this pull request as ready for review August 25, 2023 22:05
@iliana
Copy link
Contributor Author

iliana commented Aug 25, 2023

Latest commit is a re-do and does a handful of other things too. The pull request description is updated with details.

Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxidecomputer/buildomat#36 makes it somewhat annoying to test the repos from this PR, but we really need this to land. Do you think we should:

  • Merge as-is; the buildomat issue is inconsistent so doesn't totally preclude using the resulting repos
  • Revert the removal of splitting the zip up into < 1 GiB pieces and then merge?

I have a very slight preference for the latter but am fine with either.

@iliana
Copy link
Contributor Author

iliana commented Sep 5, 2023

I'm honestly surprised that just slightly above >1 GiB seems to be the point where failures seem to occur in oxidecomputer/buildomat#36. So I am also slightly in favor of dropping the combined repo for now. I will get that pushed and then merge on success.

@iliana
Copy link
Contributor Author

iliana commented Sep 5, 2023

I also now have the opportunity to remove the PVT1 repo, since that rack has been updated enough to understand multiple SP image revisions. That is done.

Will merge once everything passes, and notify the dogfood channel (and update the script in the instructions) for the updated repo series naming ("dogfood" -> "rot-staging-dev").

@iliana iliana changed the title [ci/tuf-repo] multi-SP repos + use released SP images + add gimlet-e + stop splitting the repo [ci/tuf-repo] multi-SP repos + use released SP images + add gimlet-e Sep 5, 2023
@iliana iliana merged commit f58287b into main Sep 5, 2023
@iliana iliana deleted the iliana/megarepo branch September 5, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants