Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README to set RUSTDOCFLAGS too #224

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

davepacheco
Copy link
Collaborator

See #213. I somehow missed that if you try to work around this by setting RUSTFLAGS at build time but not RUSTDOCFLAGS, then the oximeter doc-tests fail as well:

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests oximeter

running 8 tests
test src/traits.rs - traits::Metric (line 117) ... ok
test src/traits.rs - traits::Target (line 50) ... ok
test src/traits.rs - traits::Metric (line 124) ... ok
test src/traits.rs - traits::Target (line 24) ... FAILED
test src/traits.rs - traits::Producer (line 202) ... FAILED
test src/histogram.rs - histogram::Histogram<T>::with_bins (line 246) ... FAILED
test src/traits.rs - traits::Metric (line 99) ... FAILED
test src/histogram.rs - histogram::Histogram (line 191) ... FAILED

failures:

---- src/traits.rs - traits::Target (line 24) stdout ----
Test executable failed (terminated by signal).

stderr:
ld.so.1: rust_out: fatal: libpq.so.5: open failed: No such file or directory


---- src/traits.rs - traits::Producer (line 202) stdout ----
Test executable failed (terminated by signal).

stderr:
ld.so.1: rust_out: fatal: libpq.so.5: open failed: No such file or directory


---- src/histogram.rs - histogram::Histogram<T>::with_bins (line 246) stdout ----
Test executable failed (terminated by signal).

stderr:
ld.so.1: rust_out: fatal: libpq.so.5: open failed: No such file or directory


---- src/traits.rs - traits::Metric (line 99) stdout ----
Test executable failed (terminated by signal).

stderr:
ld.so.1: rust_out: fatal: libpq.so.5: open failed: No such file or directory


---- src/histogram.rs - histogram::Histogram (line 191) stdout ----
Test executable failed (terminated by signal).

stderr:
ld.so.1: rust_out: fatal: libpq.so.5: open failed: No such file or directory



failures:
    src/histogram.rs - histogram::Histogram (line 191)
    src/histogram.rs - histogram::Histogram<T>::with_bins (line 246)
    src/traits.rs - traits::Metric (line 99)
    src/traits.rs - traits::Producer (line 202)
    src/traits.rs - traits::Target (line 24)

test result: FAILED. 3 passed; 5 failed; 0 ignored; 0 measured; 0 filtered out; finished in 14.66s

error: test failed, to rerun pass '--doc'

@davepacheco davepacheco merged commit 55b120a into main Sep 9, 2021
@davepacheco davepacheco deleted the issue-213-rustdocflags branch September 9, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants