Add host startup options support to Grapefruit #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
force-pushed
the
mkeeter/grapefruit-host-startup
branch
from
299fbd7 to
6f24f7b
Compare
citrus-it
reviewed
Jan 21, 2025
task/packrat/src/grapefruit.rs
Outdated
| // We have to do this because const fn. | ||
| let bits = HostStartupOptions::STARTUP_KMDB.bits() | ||
| | HostStartupOptions::STARTUP_PROM.bits() | ||
| | HostStartupOptions::STARTUP_VERBOSE.bits(); |
There was a problem hiding this comment.
Can we have HostStartupOptions::STARTUP_BOOT_RAMDISK.bits() in this default set too please?
There was a problem hiding this comment.
Right, you did ask for that in the initial issue! I guess we should also be building packrat with the boot-kmdb feature, to get this set of bits?
There was a problem hiding this comment.
(fixed in 8bbbda7)
There was a problem hiding this comment.
Yes, I think for grapefruit we're not likely to want to have the same concept of a non-lab image (where the bits would default to 0), at least for now.
mkeeter
force-pushed
the
mkeeter/grapefruit-host-startup
branch
from
6f24f7b to
8bbbda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1983