-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oxide-barcode: allow shorter serial and part numbers #1939
Conversation
2350274
to
080b605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handful of very unimportant nits, feel free to disregard me.
I flashed these changes to a rev B bench gimlet which has an unlocked VPD, then replaced the VPD contents with a v2 barcode containing short part and serial numbers:
and booted. The board properties (and their length) printed as the kernel starts up look good:
and sending an IPCC ident command from the running OS also shows the expected results:
The
|
This retains the original maximum length for both fields, but permits parsed strings to contain shorter sections. Shorter sections are right-padded with NULs for consistency with IPCC. Fixes #1893
080b605
to
cee98c9
Compare
This retains the original maximum length for both fields, but permits parsed strings to contain shorter sections. Shorter sections are right-padded with NULs for consistency with IPCC.
Fixes #1893