Remove lease limit from qspi_read
#1911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mkeeter
force-pushed
the
delimit-qspi-read
branch
from
e644e7b to
94e3c0f
Compare
hawkw
reviewed
Nov 6, 2024
| /// This function will only return an error if it fails to read from a | ||
| /// This function will only return an error if it fails to write to a |
| @@ -269,6 +269,7 @@ impl FlashDriver { | |||
| } | |||
| } | |||
| } | |||
| offset += len as u32; | |||
There was a problem hiding this comment.
should we be doing something to avoid a panic site from the overflow check here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Grapefruit (where I found that we weren't updating the offset address!); eyeballed on Gimlet.