New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a test to ensure that chunked encoding obeys request size limits #620

Open

sunshowers wants to merge 1 commit into sunshowers/spr/main.add-a-test-to-ensure-that-chunked-encoding-obeys-request-size-limits from sunshowers/spr/add-a-test-to-ensure-that-chunked-encoding-obeys-request-size-limits

Contributor

sunshowers commented Mar 21, 2023 •

edited

Loading

There were no functional changes required -- chunked encoding already
obeys request size limits. Add a test which checks that.

Also simplify the test to not have to create a temporary file, instead
serving a stream purely from memory.

Depends on #617 and #618, since the test uses the StreamingBody and max
request size functionality introduced in those two PRs respectively.

Closes #545.


          [𝘀𝗽𝗿] initial version

189fbc7

Created using spr 1.3.4

sunshowers requested review from davepacheco and ahl

March 21, 2023 19:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet