[DRAFT - DO NOT MERGE] Basic OpenTelemetry integration #1201
+2,354
−637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshalman
force-pushed
the
otel-tracing
branch
from
508eb58 to
76af80a
Compare
nshalman
commented
Dec 12, 2024
Comment on lines
+89
to
+90
| #[cfg(feature = "otel-tracing")] | ||
| pub span_context: opentelemetry::trace::SpanContext, |
There was a problem hiding this comment.
This is gross and I need something better.
Comment on lines
+382
to
+394
| impl std::fmt::Display for HandlerError { | ||
| fn fmt(&self, f: &mut Formatter) -> FmtResult { | ||
| write!( | ||
| f, | ||
| "{}", | ||
| match self { | ||
| Self::Handler { ref message, .. } => message, | ||
| Self::Dropshot(ref e) => &e.external_message, | ||
| } | ||
| ) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this is for tokio-tracing and could potentially be dropped or separated into a dedicated commit. Really all the tokio-tracing bits should be a separate commit now that I think about it.
nshalman
force-pushed
the
otel-tracing
branch
from
76af80a to
04c7da7
Compare
nshalman
force-pushed
the
otel-tracing
branch
from
04c7da7 to
1a5061c
Compare
nshalman
force-pushed
the
otel-tracing
branch
from
c86d59b to
1db15e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry for Dropshot
This is still very much a rough draft, but I want it to be clearly available for anyone interested.
Checklist of things that are needed (note that much of it is currently incomplete):
Known Issues
dtrace.conf(24) References
Slides:
https://docs.google.com/presentation/d/1AW_ugVrmkXDTROgPbEt7bCLrLhFo8-z13PoJAdfPO78/
Raw video link:
https://www.youtube.com/watch?v=KQN1t2qlhaw&t=11760s
Screenshot