Don't depend on React Router or Remix directly #106
Conversation
| <Link | ||
| to={`#${item.id}`} | ||
| <a | ||
| href={`#${item.id}`} |
There was a problem hiding this comment.
Turns out these are fragment links, so there's no advantage to Link that I know of.
|
Canary has the desired effect in oxidecomputer/console#2637 |
|
Sounds good. Will check it works on either the RFD site or docs. If we ever wanted to reintroduce components that had a link – for example for something like a shared dropdown link item, would we re-add the peer dep since we'd likely be using react router for everything at that point? |
|
I guess it would be less problematic if everything was on RR 7. Another thing we might consider is breaking up this package so that the asciidoc stuff was in its own package. |
|
Ran in to a conflict with the peer dep version today when trying to update remix for the RFD site. It would be nice if they could be decoupled. |
|
Was investigating updating to rr 7, and this (depending on |
david-crespo
force-pushed
the
remove-rr
branch
from
cb76f55 to
f653b01
Compare
|
Will leave this as minor so we don't have too much churn on the major version. It is a breaking change to calling code that uses the delegated links hook (one repo) but shouldn't require anyone to change their deps. |
david-crespo
changed the title
|
I think we're gonna go with this. I have a PR to the RFD site that will make sure this change works. Unfortunately I am having trouble pushing a branch. |
|
@steveklabnik and @augustuswm you should be able to use |
|
worked great, thanks! |
|
Thanks! Will test it tomorrow |
|
🚀 PR was released in |
Closes #86
Will need to test it in an app that uses the delegated links hook to make sure passing
navigateworks as expected.@charliepark and I ran into this while updating oxidecomputer/console#2576 — there was a stray remaining
react-router-domimport that should have errored out, but we had a dep onreact-router-domthrough design-system.