Remove more unnecessary DsState variants
#1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
force-pushed
the
mkeeter/remove-more-states
branch
3 times, most recently
from
a6d1a0d to
81b65c5
Compare
mkeeter
force-pushed
the
mkeeter/consolidate-reinitialize
branch
from
7c40c94 to
a9d7090
Compare
mkeeter
force-pushed
the
mkeeter/remove-more-states
branch
2 times, most recently
from
9f06089 to
9d73e80
Compare
leftwo
approved these changes
Nov 4, 2024
| * │ │ ▼ └───►───┐ │ ║ ║ | ||
| * │ bad│ ┌────┴──────┐ │ │ ║ ║ | ||
| * │ region│ │ Wait │ │ │ ║ ║ | ||
| * │ │ ▼ └───►───┐ other │ ║ ║ |
There was a problem hiding this comment.
Heh, we probably don't need the arrow going form new -> new.
jmpesp
reviewed
Nov 5, 2024
Comment on lines
+718
to
+719
| * │ │ ▼ └───►───┐ other │ ║ ║ | ||
| * │ bad│ ┌────┴──────┐ │ failures ║ ║ |
There was a problem hiding this comment.
Any other failures, other than the connection going away?
There was a problem hiding this comment.
Yeah, going back to New is the universal behavior for any failures before going active.
mkeeter
force-pushed
the
mkeeter/remove-more-states
branch
from
9d73e80 to
f610a22
Compare
jmpesp
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(staged on top of #1549)
DsState::Migratingis not yet implementedDsState::Disconnectedis another transient state (see Remove transient states inDsState#1526). It's assigned inDownstairsClient::restart_connection(which halts the IO task), then we switch toDsState::Newonce the IO task halts. Those two states are never actually handled differently, so we can switch toDsState::Newimmediately