Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we have two types with the same shape:
The
DownstairsIO
stores both of these types:By the time we write to
data
, the block contexts have already been validated, so storing them again inhashes
adds unnecessary duplication (and they're guaranteed to be the same).This PR removes the duplicate
Validation
hashes, using theRawReadResponse::blocks
member instead.There are small changes to
GuestBlockRes::transfer_and_notify
andBuffer::write_read_response
, because we can't take the entireOption<RawReadResponse>
; instead, we pass the&mut BytesMut
separately, so it can be sent back to the host.