New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups to `print_last_completed` #1501

Merged

mkeeter merged 1 commit into main from mkeeter/cleanup-print-last-completed

Oct 10, 2024

Contributor

mkeeter commented Oct 10, 2024

Don't reallocate into a Vec<..>; just print from the AllocRingBuf<..>
Don't print (incorrect) header in print_last_completed; instead, print it in the caller


Minor cleanups to print_last_completed

57ab1bd

mkeeter requested review from jmpesp and leftwo

October 10, 2024 14:57

leftwo approved these changes

View reviewed changes

mkeeter merged commit c44cd76 into main

19 checks passed

mkeeter deleted the mkeeter/cleanup-print-last-completed branch

October 10, 2024 18:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment