Remove remaining Arc<Volume>
instances
#1500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested volumes use an
Arc<dyn BlockIO + Send + Sync>
to represent the innerBlockIO
device.Previously, we implemented the
BlockIO
trait on thestruct Volume
itself, so we needed to make anArc<Volume>
to create nested volumes.This PR moves the
BlockIO
implementation to theVolumeInner
. Because theVolumeInner
is already stored in anArc
, we can now cast fromArc<VolumeInner>
toArc<dyn BlockIO + Send + Sync>
, removing the extra level of indirection.