Add region set options to more tests. #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give test_live_repair, test_replace_special, and test_replay an option to indicate how many region sets should be created for the test. This allows us to use the same script to test single and multiple sub-volumes. Updated a few of the tests to no longer run a smaller test in a loop, but instead just run a longer test. This makes better sense when testing many sub-volumes as a smaller test might not cover everything. It has the side effect of not printing regular status messages, but if we find that is important we can come up with another way of displaying test progress.
mkeeter
reviewed
Oct 7, 2024
| if ! "$crucible_test" fill --dsc 127.0.0.1:9998 -q -g "$gen"\ | ||
| --verify-out "$verify_log" >> "$test_log" 2>&1 ; then | ||
| echo Failed on initial verify seed, check "$test_log" | ||
| --skip-verify >> "$test_log" 2>&1 ; then |
There was a problem hiding this comment.
The addition of --skip-verify, yeah, that's just to go a little faster.
We don't bother with the --verify-out any longer because we are not stopping and starting crutest several times, so we no longer need to read in the verify info from the previous loop.
The stopping/starting part of the test here was causing problems when we have multiple region sets. The region set that we ended the previous test loop on might not match up with the region set that we start with by default.
mkeeter
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give test_live_repair, test_replace_special, and test_replay an option to indicate how many region sets should be created for the test. This allows us to use the same script to test single and multiple sub-volumes.
Updated a few of the tests to no longer run a smaller test in a loop, but instead just run a longer test. This makes better sense when testing many sub-volumes as a smaller test might not cover everything. It has the side effect of not printing regular status messages, but if we find that is important we can come up with another way of displaying test progress.
Future PRs will use these options to increase test coverage on multiple sub-volumes.