Update more tests to use dsc #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give crutest the list of targets it will be operating on so some tests that need that list of targets can still get it. Updated more tests to use dsc to determine targets instead of having to provide them on the command line. Updated most of test_up.sh to use dsc for targets instead of supplying them on the command line.
mkeeter
reviewed
Sep 27, 2024
| let dsc_client = Client::new(&dsc_str); | ||
| Workload::ReplaceBeforeActive { replacement } => { | ||
| let dsc_client = match opt.dsc { | ||
| Some(dsc_addr) => { |
There was a problem hiding this comment.
This is a small behavior change: previously, there was a default value of http://127.0.0.1:9998; now, we return an error. Dunno if the change is intentional or not!
There was a problem hiding this comment.
Yeah, before it assumed that any dsc it finds at the default would be correct, but that
may not be what the user wanted. More so now that there is a global dsc option which
should be what these tests use. Hopefully fewer surprises as this makes the dsc server
target required.
mkeeter
reviewed
Sep 27, 2024
| } => { | ||
| let dsc_client = Client::new(&dsc_str); | ||
| Workload::ReplaceReconcile { replacement } => { | ||
| let dsc_client = match opt.dsc { |
There was a problem hiding this comment.
Same here (there was previously a default value for dsc_str)
mkeeter
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is plucking out non
BlockIOparts from: #1474Give crutest the list of targets it will be operating on so some tests that need that list of targets can still get it.
Updated more tests to use dsc to determine targets instead of having to provide them on the command line.
Updated most of test_up.sh to use dsc for targets instead of supplying them on the command line.
There is still some work required to get hammer tests to use dsc, if we decide to do that.