Skip to content

Commit

Permalink
More PR comments addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
leftwo committed Feb 2, 2024
1 parent 7bef555 commit 89f98d6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
10 changes: 0 additions & 10 deletions downstairs/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -260,16 +260,6 @@ async fn main() -> Result<()> {
source,
trace_endpoint,
} => {
/*
* If any of our async tasks in our runtime panic, then we should
* exit the program right away.
*/
let default_panic = std::panic::take_hook();
std::panic::set_hook(Box::new(move |info| {
default_panic(info);
std::process::exit(1);
}));

// Instrumentation is shared.
if let Some(endpoint) = trace_endpoint {
let tracer = opentelemetry_jaeger::new_agent_pipeline()
Expand Down
11 changes: 1 addition & 10 deletions downstairs/src/repair.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,7 @@ pub async fn repair_main(
let ds = ds.lock().await;
let region_dir = ds.region.dir.clone();
let read_only = ds.read_only;
let rd = region::config_path(region_dir.clone());
let region_definition = match read_json(&rd) {
Ok(def) => def,
Err(e) => {
return Err(format!(
"Can't get region definition from {:?}: {:?}",
rd, e
));
}
};
let region_definition = ds.region.def();
drop(ds);

info!(log, "Repair listens on {} for path:{:?}", addr, region_dir);
Expand Down

0 comments on commit 89f98d6

Please sign in to comment.