Skip to content

Commit

Permalink
Remove ackable_work; ack immediately instead (#1552)
Browse files Browse the repository at this point in the history
A long time ago, one task accumulated ackable jobs into
`Downstairs::ackable_work` and a different task periodically read out
that set and sent acks back to the guest.

The tasks have long since been consolidated, but the `ackable_work` set
remained.

This PR removes the `ackable_work` set, acking jobs immediately when
they are ready. It's a significant LOC simplification, because it's
removing intermediate state (which previously had to be checked in unit
tests).

There's one subtlety in handling live-repair: previously, the
live-repair check would look in `ackable_work` to see if the next job
was ackable, which indicates that live-repair can continue. Now, we
update the `LiveRepairState` directly in `Downstairs::ack`, storing a
result for the pending live-repair job.
  • Loading branch information
mkeeter authored Nov 15, 2024
1 parent e034d19 commit 515725c
Show file tree
Hide file tree
Showing 2 changed files with 395 additions and 655 deletions.
Loading

0 comments on commit 515725c

Please sign in to comment.