Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read-only UI for internet gateways #2488

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

charliepark
Copy link
Contributor

@charliepark charliepark commented Oct 7, 2024

Closes #2402

The intent is — at the moment — to create a read-only view of the Internet Gateways, and to then iterate on it in future releases, adding create/update/delete functionality.

We're still pulling a bit of this together, but it's close, and as Omicron just got updated to include internet gateways, I figured it would be good to start a PR so we can talk through a few of the specific choices and what we might want to do differently.

I think our demo Internet Gateways / IG IP Pools / IG IP Addresses in the mock db can be improved, as there's currently a fair amount of duplication that ends up confusing things.

So this is still a draft, as I figure we have some things to talk through.

Nevertheless, here's the stub of the tabbed pages for Internet Gateways:
Screenshot 2024-10-07 at 12 34 57 AM

Screenshot 2024-10-07 at 12 35 04 AM

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Oct 10, 2024 3:42am

@benjaminleonard
Copy link
Contributor

In general I think we're better off holding for the next release to get the implementation right for churn reasons.

Let's catch up on this today. I might be a helpful eye for this, since I haven't read up on internet gateways yet, so I can play the idiot seeing this for the first time – a role a know and love.

I notice we're also missing breadcrumbs – is that #1527 ?

@charliepark
Copy link
Contributor Author

Good point on the breadcrumbs. Have added those in, but I think your larger point is a good one — there'll be more than just the breadcrumbs to discuss, and holding back on the feature for a release to get it right could be the better call. Will look forward to talking through it.

Comment on lines +86 to +88
<PropertiesTable.Row label="ID">
<Truncate text={id} maxLength={32} hasCopyButton />
</PropertiesTable.Row>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary, as we have the MoreActionsMenu button in the header with the Copy ID button, but I didn't see a clear "fourth" aspect to the internet gateway metadata to highlight. If we do keep this, we can drop the MoreActionsMenu, as it's redundant. I suspect dropping this one is the better approach, though, if we can figure out what to put here in its place.

@charliepark charliepark changed the title Internet gateways 2 Add read-only UI for internet gateways Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internet gateways tab on VPC page
2 participants