Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank flash while loading the next page #1862

Closed
wants to merge 2 commits into from

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Dec 15, 2023

Closes #1861

We could use a loading indicator while the next page loads, though. It just sits there until it changes, no feedback on click.

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Feb 28, 2024 9:08pm

@david-crespo
Copy link
Collaborator Author

This works but I noticed it does not scroll you to the top when the next page loads — it leaves you at the same spot. The blank flash version doesn't have this problem because you automatically get scrolled to the top when the page is empty. So that would have to be fixed here.

@benjaminleonard
Copy link
Contributor

Adding Eugene to assist with the design of this. The top loading bar doesn't show up because this isn't a route change right?
We could loop this into #1995 – that is the same spinner that appears when the data is refreshed is used for page changes.

P.S. Making a note that we should discuss pagination (and other filtering) included in the URL or not when we get sorting and filtering.

@david-crespo
Copy link
Collaborator Author

Closing, will pick this back up at some point. Probably part of #2029.

@david-crespo david-crespo deleted the fix-query-table-flash branch April 24, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page goes blank while loading next page
3 participants