Use RHF validation mode onTouched instead of all
#1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
rhf-validation-mode
branch
from
1e2d9b9
to
5621ba3
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 4, 2023
oxidecomputer/console@af6536d...0cc1e03 * [0cc1e03a](oxidecomputer/console@0cc1e03a) oxidecomputer/console#1770 * [48aea2f4](oxidecomputer/console@48aea2f4) npm audit fix * [84aff1de](oxidecomputer/console@84aff1de) oxidecomputer/console#1769 * [c127febd](oxidecomputer/console@c127febd) oxidecomputer/console#1768 * [8c9513c1](oxidecomputer/console@8c9513c1) oxidecomputer/console#1765 * [0314fd72](oxidecomputer/console@0314fd72) oxidecomputer/console#1742 * [8918ffa9](oxidecomputer/console@8918ffa9) skip the other flaky test in safari for now. I'm suffering * [b357246e](oxidecomputer/console@b357246e) increase playwright total time to 20 minutes * [4f7d401d](oxidecomputer/console@4f7d401d) be sneakier about PR numbers in commit messages in bump omicron PR
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 4, 2023
The only functional change should be the form validation one. And one icon. But there are some tweaks to our build setup that I'd like to make sure we didn't mess up. oxidecomputer/console@af6536d...0cc1e03 * [0cc1e03a](oxidecomputer/console@0cc1e03a) oxidecomputer/console#1770 * [48aea2f4](oxidecomputer/console@48aea2f4) npm audit fix * [84aff1de](oxidecomputer/console@84aff1de) oxidecomputer/console#1769 * [c127febd](oxidecomputer/console@c127febd) oxidecomputer/console#1768 * [8c9513c1](oxidecomputer/console@8c9513c1) oxidecomputer/console#1765 * [0314fd72](oxidecomputer/console@0314fd72) oxidecomputer/console#1742 * [8918ffa9](oxidecomputer/console@8918ffa9) skip the other flaky test in safari for now. I'm suffering * [b357246e](oxidecomputer/console@b357246e) increase playwright total time to 20 minutes * [4f7d401d](oxidecomputer/console@4f7d401d) be sneakier about PR numbers in commit messages in bump omicron PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1761
Does not do #1289 because it still validates on that first blur even if you didn't type anything.
onTouchedvalidates first on blur, and after that on change. I think I like that, but I'm flexible.onBluris almost the same except it always validates on blur instead of change. The annoying thing to me about blur only is that if you go into a field with a validation error and correct it, the error won't go away until you blur. I find that a little surprising.On the implementation side I considered just replacing
mode: 'all'withmode: 'onTouched'in all the call sites, and could definitely change it to that, but it feels slightly less error-prone to me to use the shared wrapper, and then you don't have the noise of themodeat every call site.Full table of
modeoptions from the RFD docs2023-10-04-rhf-onTouched.mp4